Add worker deployments for spackbotdev #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwryankrattiger
force-pushed
the
spackbot_pr_binary_graduation
branch
3 times, most recently
from
6e87bcb to
6ac1e6d
Compare
Collaborator
Author
|
@zackgalbreath I moved the close stuff to spackbot since I am also deleting the mirror there spack/spackbot#68 Could you review those changes to make sure I didn't break something else as well. |
zackgalbreath
requested changes
Oct 27, 2022
scottwittenburg
requested changes
Nov 8, 2022
Collaborator
scottwittenburg
left a comment
scottwittenburg
left a comment
There was a problem hiding this comment.
This is looking pretty good @kwryankrattiger thanks! Couple requests:
I feel like this is not rebased on the latest main, to make it easier for me to make another review pass, can you rebase it?
Somehow the nested contents of the volumes and volumeMounts sections in the deployments are indented differently between spackbot-spack-io and spackbotdev-spack-io. Can you make them match?
Thanks!
kwryankrattiger
force-pushed
the
spackbot_pr_binary_graduation
branch
from
1db170d to
6904660
Compare
kwryankrattiger
force-pushed
the
spackbot_pr_binary_graduation
branch
from
bff8ab0 to
289061b
Compare
scottwittenburg
approved these changes
Nov 11, 2022
zackgalbreath
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@scottwittenburg